Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to combinetf2 #575

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Migration to combinetf2 #575

wants to merge 25 commits into from

Conversation

davidwalter2
Copy link
Collaborator

@davidwalter2 davidwalter2 commented Dec 11, 2024 •
edited
Loading

  • Update narf to more feature complete version Adding nuisance parameter impacts bendavid/narf#29
  • Migrate CI to combinetf2, remove CMSSW dependencies needed for combinetf1
  • Remove support for root output in setupCombine.py
  • Remove masked channel functionality
  • Remove support for combinetf1 in postfitPlots.py, impact plots and other scripts. Still keep the functions in the io tools for now.

on top of #562

@davidwalter2
Remove LnN uncertainty interface; remove lumi scaling histograms to c…
ab48337 
…onstruct uncertainty in setupCombine
@davidwalter2
Fix definition of MCnoQCD to fix preOp in addSystematic
c88b711
@davidwalter2
Remove residual lumi histograms; implement option to float W normaliz…
acac317 
…ation in fit
@davidwalter2
Merge branch 'main' of github.com:WMass/WRemnants into 241114_fixNormUnc
088b4ed
@davidwalter2
Don't propagate normalization uncertainties into the fake estimation …
c99d2db 
…for now, to keep synchronized with unblinding conditions
@davidwalter2
Adapt all but unfolding to combinetf2
029aa25
@davidwalter2
linting
b96348e
@davidwalter2
Remove specific groups from combinetf1 that are no longer supported a…
1637424 
…nd masked channel support
@davidwalter2
Fix impacts and CI
3c0d250
@davidwalter2
Small fixes
2b988c2
@davidwalter2
Fix unfolding for CI
74348b9
@davidwalter2
Remove support for simultaneous ABCD and for setupCombine root output
ed4f0d4
@davidwalter2
dump nar
72e2653
@davidwalter2
Small fixes
96c6c06
@davidwalter2
Merge branch 'main' of github.com:WMass/WRemnants into 241211_to_comb…
c49ce71 
…inetf2
@davidwalter2
Merge branch '241114_fixNormUnc' of github.com:davidwalter2/WRemnants…
8e4ba92 
… into 241211_to_combinetf2
@davidwalter2
Fix CI and postfit plots
86722dd
@davidwalter2
Adapt unfolding workflow to combinetf2
71eda89
@davidwalter2
Run everything in singularity
79f8e24
@davidwalter2
Revert "Run everything in singularity"
8f1b36a 
This reverts commit 79f8e24.
@davidwalter2
Adapt theory fit to combinetf2
e15e995
@davidwalter2
Merge branch 'main' of github.com:WMass/WRemnants into 241211_to_comb…
e9607ee 
…inetf2
@davidwalter2
Remove unused import
1e97755
@davidwalter2
Dump narf; fixes on previous changes
77b80c0
@davidwalter2 davidwalter2 force-pushed the 241211_to_combinetf2 branch 2 times, most recently from a065696 to e0e5ce2 Compare December 20, 2024 09:39
@davidwalter2 davidwalter2 marked this pull request as ready for review December 20, 2024 09:50
@davidwalter2 davidwalter2 force-pushed the 241211_to_combinetf2 branch 2 times, most recently from 68affef to 6d00a16 Compare December 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidwalter2